Relocate and document Time::DayOfWeek #5188
Merged
+25
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate
Time::DayOfWeek
definition insideTime
, adding documentation and examples on its usage.Refactor day question methods (ie
#monday?
) macro to use Enum's constants and question methods, avoiding duplication of definitions.This change does not introduce performance penalties by itself, but a synthetic benchmark might present it otherwise:
Benchmark code:
Apologies for submitting a refactor without starting a discussion about it first, but this has been a nitpick I had with
Time
when was exploring the codebase.I know doesn't introduce lot of value, but had the changes locally so thought, why not? 😁
Thank you in advance for your review.
❤️ ❤️ ❤️