New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treewide: abandon Google Code homepages #30846
Conversation
Don't merge yet, it needs some more work |
821cf94
to
d5d5a79
Compare
Ok not wip anymore. I just completed successfully a Result in /run/user/1000/nox-review-1i83i6xc
total 0
lrwxrwxrwx 1 renaud users 56 28 oct. 01:37 result -> /nix/store/ygk4rak9hy7cig1501fqwzp73w7iz3a5-amarok-2.8.0
lrwxrwxrwx 1 renaud users 67 28 oct. 01:37 result-10 -> /nix/store/ppgazy2x6b8dxwhspd35x4w9wlannnaz-qtscriptgenerator-0.1.0
lrwxrwxrwx 1 renaud users 56 28 oct. 01:37 result-11 -> /nix/store/swfi0cjwxybk913fi167bs202haifxz8-arora-0.11.0
lrwxrwxrwx 1 renaud users 53 28 oct. 01:37 result-12 -> /nix/store/04m2rw2dh4fiaw6x6xzaw8y44s9l3bmj-kippo-0.8
lrwxrwxrwx 1 renaud users 57 28 oct. 01:37 result-13 -> /nix/store/1wzzdsvmp7fhx8bkxw8k64qyv2blj5hl-hyenae-0.36-1
lrwxrwxrwx 1 renaud users 56 28 oct. 01:37 result-2 -> /nix/store/ra78vja84m37zcjjkq80m27y0nghw6x4-udptunnel-19
lrwxrwxrwx 1 renaud users 65 28 oct. 01:37 result-3 -> /nix/store/pzb7rfxs6kmr60vrxrlrgjvwfl1hh5y5-open-vm-tools-10.1.10
lrwxrwxrwx 1 renaud users 68 28 oct. 01:37 result-4 -> /nix/store/977jh7plhs9fl0r5iiy79isjxn9p5rrp-fcitx-mozc-2.20.2673.102
lrwxrwxrwx 1 renaud users 58 28 oct. 01:37 result-5 -> /nix/store/0pyk5rz69939ig4hhhiniw5z7y0d54s9-gwt-java-2.4.0
lrwxrwxrwx 1 renaud users 53 28 oct. 01:37 result-6 -> /nix/store/93fvm0sya7xz1g25jxc9d0ckpq9yb9lz-daq-2.0.6
lrwxrwxrwx 1 renaud users 56 28 oct. 01:37 result-7 -> /nix/store/yiwpxg4v87bxxaq96v5g5iiivx5ibmfg-libdnet-1.12
lrwxrwxrwx 1 renaud users 57 28 oct. 01:37 result-8 -> /nix/store/ns31pqgrwfqdz62klqkr83rgic187djd-snort-2.9.8.2
lrwxrwxrwx 1 renaud users 65 28 oct. 01:37 result-9 -> /nix/store/y5r4c891dab83dqpg57hw8mg6a93pxwy-open-vm-tools-10.1.10 It took a little time, mostly in the build of kdelibs-4.14.36 |
Some websites (e.g. garmintools) do not look very official |
It would also be good to afterwards go through this list of packages and see which we want to keep. I already see some old and unmaintained packages which we should drop. |
Thanks for the feedbacks. @jtojnar yes it's always a bit tricky when the former Gcode repo does not provide an explicit link to a new home. Two changes I made are debatable : @FRidh yes some of them are clearly outdated but I found myself reluctant to mark them as broken because as long as the source are available and it compiles, someone might still be using it (inside or outside of the nixpkgs tree). Two obvious cases though:
-> Should I mark these 2 as broken ? |
Fixed the homepages for garmintools and gtkdialog (back to the archived GCode page). slimrat and tmin are marked as broken. |
Concerns here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0bw3b Thank you for finding the substitutes for all these URLs!
I've enabled the parallel building for qtscriptgenerator
because nox-review
was too slow.
Oh yes good call! Indeed the nox-review I ran before took some time with kdelibs... There is still some more G.Code homepages in the repo but that is a good start I believe. |
@@ -5,7 +5,7 @@ stdenv.mkDerivation rec { | |||
version = "0.11.0"; | |||
|
|||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be replaced by fetchFromGitHub
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, done in 930414e
Motivation for this change
Part of the #30636 effort
This PR updates homepages of packages that were hosted on Google Code.
When necessary I also updated the source URL in order to use the Google API storage archive:
https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/projectname/filename
It returns the same file so hashes were not updated but it may still trigger some rebuilds.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)