Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appstream: fix homepage url #30841

Closed
wants to merge 1 commit into from
Closed

appstream: fix homepage url #30841

wants to merge 1 commit into from

Conversation

mimame
Copy link
Member

@mimame mimame commented Oct 26, 2017

Motivation for this change

Fix homepage url. Related to #30636

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

matthewbauer commented Oct 26, 2017 •
edited

Nice work @mimadrid !

In the future though, I think it's fine to combine multiple homepage changes into one PR (multiple commits though). That's at least how I did it here: #28475.

@mimame
Copy link
Member Author

mimame commented Oct 27, 2017

Thanks a lot for the advice @matthewbauer. I thought it was better in that way for a more easily tracking to the metabug.

@rycee
Copy link
Member

rycee commented Oct 28, 2017

Rebased to master in 19828e8. Thanks!

@rycee rycee closed this Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimame @matthewbauer @rycee @jtojnar