Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt-python: 3.6.0 -> 3.8.0 #30862

Closed
wants to merge 1 commit into from
Closed

libvirt-python: 3.6.0 -> 3.8.0 #30862

wants to merge 1 commit into from

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

fixed build, as assert in pkgs/top-level/python-packages was failing
due to version mismatch between libvirt{,-python}

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ikervagyok
libvirt-python: 3.6.0 -> 3.8.0
16080da 
fixed build, as assert in pkgs/top-level/python-packages was failing
due to version mismatch between libvirt{,-python}
@andir
Copy link
Member

andir commented Oct 27, 2017 •
edited

LGTM. This fixes everyone on channels/nixos-unstable that is using libvirt since the current HEAD there is broken due to the assertion in the python module.

@FRidh
Copy link
Member

FRidh commented Oct 27, 2017

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

@pbogdan
Copy link
Member

pbogdan commented Oct 27, 2017

Looks like it's already been fixed in master via a7449bf?

@ikervagyok ikervagyok closed this Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikervagyok @andir @FRidh @pbogdan