Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: pymysql 0.6.6 -> 0.7.11 #30858

Closed
wants to merge 1 commit into from

Conversation

esoeylemez
Copy link
Contributor

No description provided.

@FRidh
Copy link
Member

FRidh commented Oct 27, 2017

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

@orivej
Copy link
Contributor

orivej commented Nov 3, 2017

@FRidh Why do we ask people to move packages? Shouldn't we move everything automatically?

@orivej orivej mentioned this pull request Nov 3, 2017
8 tasks
@FRidh
Copy link
Member

FRidh commented Nov 3, 2017

@orivej any suggestion on how to do this automatically?

Reasons for moving:

  1. reduce size of python-packages.nix
  2. reduces merge issues
  3. easier to track history
  4. individual expressions can more easily be manipulated externally. E.g., I wrote maintainers/scripts/update-python-libraries.

@orivej
Copy link
Contributor

orivej commented Nov 3, 2017

any suggestion on how to do this automatically?

I'll experiment with a few possible approaches this weekend (mainly text manipulation based vs parser based).

@esoeylemez esoeylemez closed this Jan 29, 2018
@esoeylemez esoeylemez deleted the ertes-py-pymysql branch January 29, 2018 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants