Make BigDecimal::limit work for subtraction and division. Fix issue #1615 #4830
+29
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kares
approved these changes
Oct 27, 2017
| @@ -1040,7 +1035,9 @@ public IRubyObject op_quo(ThreadContext context, IRubyObject other) { | |||
| int pow = len / 4; | |||
| int precision = (pow + 1) * 4 * 2; | |||
|
|
|||
| return divWithScale(context, val, precision); | |||
| IRubyObject result = divWithScale(context, val, precision); | |||
| if (result.getClass() == RubyBigDecimal.class) return ((RubyBigDecimal) result).setResult(); | |||
There was a problem hiding this comment.
Paranoia that there might be some hidden RubyBigDecimal subclass with strange behaviour.
Nah, it can totally be changed to instanceof.
There was a problem hiding this comment.
thx, if you get a chance please adjust - JRuby is quite in control of its sub-classes.
no need for paranoia 😉
There was a problem hiding this comment.
Sure, I pushed a fix.
|
👍 from me too. I'll merge to master and 9.1. |
|
Actually looks like there are other changes to BigDecimal on master that would need to be merged to jruby-9.1 first, like the divWithScale method. I'll try to sort it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.