Docs: Fix matching nested type references in markdown renderer #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a place where this could be specced? |
|
Unfortunately not, at least I couldn't find any. That's why I created #5309 |
|
@straight-shoota yeah I saw that right after this issue. Why not just create a place? |
|
I couldn't see an easy way to test just that change so I figured it would be to much to bootstrap a docs generator test setup just for this small fix. |
straight-shoota
force-pushed
the
jm-issue-5293
branch
from
ec755b3
to
ef06191
Compare
|
Will it merge? |
RX14
approved these changes
Dec 17, 2017
|
@Sija hopefully, although I do need someone from the core team to agree with me. |
mverzilli
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5293