Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropbox: overwrite old versions, pass arguments, fix sign-in #31772

Merged
merged 3 commits into from
Nov 17, 2017
Merged

Dropbox: overwrite old versions, pass arguments, fix sign-in #31772

merged 3 commits into from
Nov 17, 2017
+25 −3

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Nov 17, 2017

Motivation

  1. If Dropbox is installed, but the version present is older than the one we would install, overwrite the existing installation.
  2. Pass command line arguments to Dropbox in the call to exec.
  3. Fix sign-in by making a browser available in the FHS env.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ttuegel
dropbox: overwrite existing installation if our installer is newer
9ce2158
@ttuegel
dropbox: pass along positional parameters to exec
7e7fbeb
@ttuegel
dropbox: install firefox-bin in FHS env
7dee7d6 
To sign in to dropbox, a browser must be available in the FHS env. We cannot
ensure that the user's browser of choice is available, so we provide Firefox as
a default.

Resolves: NixOS#31667
@ttuegel ttuegel added the 0.kind: bug Something is broken label Nov 17, 2017
@ttuegel ttuegel self-assigned this Nov 17, 2017
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 17, 2017
@ttuegel ttuegel merged commit 850846e into NixOS:master Nov 17, 2017
@ttuegel ttuegel deleted the dropbox/versions branch November 26, 2017 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttuegel ttuegel

Labels
0.kind: bug Something is broken 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @ocharles @GrahamcOfBorg