Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtom{crypt,math}: update to 1.18.0 and 1.0.1 resp. #31376

Merged
merged 2 commits into from Nov 11, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 7, 2017

Motivation for this change

Version bump
And homepage refresh (see #30636)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 7, 2017

nox-review pr is successful on nixos-17.09

Result in /tmp/nox-review-adf20lef
total 8
lrwxrwxrwx 1 demo users 62  7 nov.  23:29 result -> /nix/store/asnjz6hf6xd0qylns346w53d8m4kwhpp-libtomcrypt-1.18.0
lrwxrwxrwx 1 demo users 60  7 nov.  23:29 result-2 -> /nix/store/94rgzbyzrcq9im843hxkyds6nn59kyr8-libtommath-1.0.1
lrwxrwxrwx 1 demo users 58  7 nov.  23:29 result-3 -> /nix/store/f2mvk3jpgwhk8zs42zvbvc3wxw6bda18-convertlit-1.8

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 8, 2017

Needs a little fixing for Darwin apparently

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 9, 2017

Fixed libtommath build on Darwin and kept libtomcrypt linux-only

The nixos-manual job of Travis jobset fails because of:

Package ‘oraclejre-8u151’ in /home/travis/build/NixOS/nixpkgs/pkgs/development/compilers/oraclejdk/jdk-linux-base.nix:80 has an unfree license (‘unfree’), refusing to evaluate.

Probably not related to my commits

@grahamc
Copy link
Member

grahamc commented Nov 11, 2017

@GrahamcOfBorg libtommath libtomcrypt

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

install -d /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1/lib/pkgconfig
install -m 644 libtommath.pc /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1/lib/pkgconfig/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1
shrinking /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1/lib/libtommath.so.1.0.1
stripping (with flags -S) in /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1/lib 
patching script interpreter paths in /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1
checking for references to /tmp/nix-build-libtommath-1.0.1.drv-0 in /nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1...
/nix/store/gafkin44by9c85wvcjl7d158z5zlys13-libtommath-1.0.1
/nix/store/6h7zz5663dcmyrifm52qxm359b0ngabl-libtomcrypt-1.18.0

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 11, 2017

Rebased on master after #31528 and all Travis jobs are ok now

@c0bw3b c0bw3b merged commit 3b647d7 into NixOS:master Nov 11, 2017
@c0bw3b c0bw3b deleted the pkg/libtom branch November 11, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants