Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir: 1.5.1 -> 1.5.2 #31379

Closed
wants to merge 1 commit into from
Closed

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Nov 8, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

Thank you for contributing to Nixpkgs! Could you read CONTRIBUTING.md and change the commit message to elixir: 1.5.1 -> 1.5.2? This helps us separate package updates from other kinds of changes, and estimate severity of the update at a glance.

@djgoku
Copy link
Contributor Author

djgoku commented Nov 8, 2017

So it looks like this has already been merged in master, but this does add a comment on how to generate the sha256 for contributors in the future.

@djgoku djgoku changed the title Bump elixir to latest version 1.5.2. elixir: 1.5.1 -> 1.5.2 Nov 8, 2017
@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

Oops, indeed it has been updated in #31259. The comment is not particularly useful since you (1) can always update the version, alter the hash a bit, try to build the package and copy the hash from the hash mismatch error, (2) can often update the version and compute the hash with e.g. nix-prefetch-url '<nixpkgs>' -A elixir.src, and adding a comment about this generic technique into that file would be out of place.

@djgoku
Copy link
Contributor Author

djgoku commented Nov 8, 2017

Yeah, it was more for future me or contributor to be able to contribute instead of fumbling around to figure our how the hash is created.

Ahh I didn't know about: nix-prefetch-url '<nixpkgs>' -A elixir.src I am going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants