Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang: 20.0 -> 20.1 #31380

Merged
merged 1 commit into from Nov 8, 2017
Merged

erlang: 20.0 -> 20.1 #31380

merged 1 commit into from Nov 8, 2017

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Nov 8, 2017

Add building of erlangR20 with odbc and javac support.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@djgoku djgoku changed the title Bump erlang version to 20.1 for erlangR20. erlang: 20.0 -> 20.1 Nov 8, 2017
@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

Thank you for updating the pull request!

@LnL7 has deleted such attributes from all packages in #26797, and we won't reintroduce them without a reason. If you want to install one, you can use either beam.interpreters.erlangR20_odbc or (erlangR20.override { odbcSupport = true; }).

In order to merge this, there has to be one commit with the right message. You can edit the commits in the push request with git rebase -i master and then git push -f.

@djgoku
Copy link
Contributor Author

djgoku commented Nov 8, 2017

Ahh ok, I think there are a few documentation updates that I could update for this: nixpkgs/doc/languages-frameworks/beam.xml - https://nixos.org/nixpkgs/manual/#how-to-install-beam-packages

nix-env -f "<nixpkgs>" -qaP -A beamPackages doesn't work for me this works though: nix-env -f "<nixpkgs>" -qaP -A beam.interpreters

Should I try to update these too?

@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

If you mean that the documentation does not mention that erlang is available with ODBC or without X and how to install them, then please update it. Otherwise it seems up to date. (It has been updated in #26668.)

beam.interpreters and beam.packages.erlang (aka beamPackages) are two different sets of packages. It seems that nix-env -f "<nixpkgs>" -qaP -A beamPackages must have been failing with error: hex-packages.nix:1550:9 called without required argument ‘redix_0_3_6’ since #16122. This is quite unfortunate. @gleber, could you help fix this?

@gleber
Copy link
Contributor

gleber commented Nov 8, 2017

beamPackages unfortunately rotted over time, since hex2nix mechanism is so hard to operate currently.

Plan to fix this is in #11748 and this issue has been reported in #26279. The only thing I can do quickly is drop most of beamPackages, since AFAIK they are not currently used by anyone.

@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

Thank you, I'm deleting transitively unbuildable packages in #31383.

@gleber
Copy link
Contributor

gleber commented Nov 8, 2017 via email

@orivej orivej merged commit 06408bd into NixOS:master Nov 8, 2017
@djgoku djgoku deleted the bump-erlang-to-20.1 branch November 9, 2017 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants