Thank you! Looking at the implementation of the breeze theme, I can see why you didn't make the branded variant independent from the breeze theme even though on the surface there is only the spinner in common. In the end though it may be better to extract it into a separate repository (if the breeze theme is independent from breeze-text.so) to make it the default NixOS theme (not restricting it to KDE users).

However, the current label under the logo is not useful or pretty. For me it reads NixOS 18.03.git.db3d846 which makes it wider than the logo, but this git part of the version is just noise. I'd suggest either using NixOS for all versions, or NixOS for unstable and NixOS 17.09 for the current release. (When the version is empty the theme adds a space after the name, which moves it off center with the logo. I guess this may be counteracted by prepending a space to the name.)

There is also a tiny issue that both commits add some spaces at the ends of the lines. It is better to configure your editor to automatically trim whitespace.

The problem with making it a separate derivation is that if you want to use the nixos branded one with a version, you need to be in a nixos context (like a module) where you have access to the version. So it seems like it has to be defined by an override in a module.

I did think about making it the default plymouth theme (IMO it's a lot nicer than the current default one), do you think I should just go ahead and do that?

I think I thought that the git suffix on the version was just if you'd built it from a git commit yourself, but I see that it's actually always there. In that case I agree, probably best to use the value of nixosRelease instead. I think it's not obvious when the user is on unstable - I could try and match on the string value of defaultChannel, but I'd rather not.

Updated to use nixosRelease and strip whitespace.

I think I'll open a separate PR to suggest making this the default, and possibly also enabling it on the live CD to make a good first impression.

Gentle ping @orivej . Are you happy with this now?

Thank you too!

This is probably for another issue, but when I enable this theme, my laptop hangs on boot to the point when it's completely unresponsive (ESC key doesn't work so I can't figure out what went wrong). If I hit ESC a bit earlier (before it hangs) and hide Plymouth, everything is fine.