dns-root-data: use a stable URL that I maintain anyway #31862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
grahamc
reviewed
Nov 20, 2017
| @@ -3,7 +3,13 @@ | |||
| let | |||
|
|
|||
| rootHints = fetchurl { | |||
| url = "https://www.internic.net/domain/named.root"; | |||
| # Original source https://www.internic.net/domain/named.root | |||
| # occasionally suffers from pointless hash changes, | |||
There was a problem hiding this comment.
Nit: they're not pointless, it receives updates.
There was a problem hiding this comment.
The last one was pointless: #31855 (comment)
There was a problem hiding this comment.
And there was another on Oct 23, as discussed on https://lists.dns-oarc.net/pipermail/dns-operations/2017-October/016865.html DNS will also work perfectly OK if a few root IPs are incorrect, so even in cases where real changes happen, some people may choose to remain on the old version to avoid rebuilds.
fpletz
approved these changes
Nov 20, 2017
vcunat
force-pushed
the
p/dns-root-data-stability
branch
from
40a24df
to
9bf3273
Compare
|
Pushed as d16b298. |
veprbl
added a commit
to veprbl/nixpkgs
that referenced
this pull request
Jan 6, 2018
This basically backports 9bf3273 ('dns-root-data: use a stable URL that I maintain anyway') /cc NixOS#31862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #31855.
/cc maintainer @fpletz.