TINSEL: Increase maximum number of objects #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be at least 374 to avoid crashes in the in-game save/load dialogues with save games using the maximum 40 letters per save game, so just round up to the next power of two (which increases memory usage by a whopping ~20KiB) to give more than enough space for long save game names. Fixes Trac#6748.
|
Agreed. This looks good to me, so merging in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be at least 374 to avoid crashes in the in-game
save/load dialogues with save games using the maximum 40 letters
per save game, so just round up to the next power of two (which
increases memory usage by a whopping ~20KiB) to give more than
enough space for long save game names.
Fixes Trac#6748.
Pretty sure this is fine, save code does not seem to care
about this object list and some quick save/load tests seemed
to work fine, but since I am not familiar with this engine it
seemed like a good idea to PR the change even though it is
otherwise trivial.