Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.locustio: 0.7.2 -> 0.8 & pythonPackages.gevent: 1.1.2 -> 1.2.2 #31863

Closed
wants to merge 2 commits into from
Closed

pythonPackages.locustio: 0.7.2 -> 0.8 & pythonPackages.gevent: 1.1.2 -> 1.2.2 #31863

wants to merge 2 commits into from
+35 −25

Conversation

adisbladis
Copy link
Member

Motivation for this change

Adds python 3 support and unbreaks pythonPackages.locustio in hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@adisbladis adisbladis requested a review from FRidh as a code owner November 20, 2017 13:02
@adisbladis adisbladis changed the title pythonPackages.locustio: 0.7.2 -> 0.8 pythonPackages.locustio: 0.7.2 -> 0.8 & pythonPackages.gevent: 1.1.2 -> 1.2.2 Nov 20, 2017
@pSub pSub added the 8.has: package (update) This PR updates a package to a newer version label Nov 22, 2017
@disassembler disassembler mentioned this pull request Nov 23, 2017
Closed
8 tasks
@disassembler
Copy link
Member

@vcunat @fpletz I closed my PR because this ones newer and does the same thing. What kind of additional testing do you think needs done for upgrading gevent?

@vcunat
Copy link
Member

vcunat commented Nov 23, 2017

I have no idea about gevent. /cc maintainer @bjornfor.

@FRidh
Copy link
Member

FRidh commented Nov 23, 2017

gevent is a common package. Last time I checked its bump, it broke quite a bit of things. We can check again.

@adisbladis
Copy link
Member Author

@FRidh It looks like these changes are pushed to master by you. Was this intentional?

See commits 4ae5f31 and 879f23e

@FRidh
Copy link
Member

FRidh commented Nov 26, 2017

@adisbladis ah, yes, it was. I had pushed them to python-unstable to test them and all looked well. I forgot to mention i there.

@FRidh FRidh closed this Nov 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adisbladis @disassembler @vcunat @FRidh @pSub @GrahamcOfBorg