Fix build breakage with current rustc: #2060
Conversation
error: the crate `bitflags` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind` error: aborting due to previous error error: the crate `bitflags` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind` error: aborting due to previous error error: Could not compile `gleam`.
|
@bors-servo r+ do you know what changed? |
|
📌 Commit f3a58bd has been approved by |
Fix build breakage with current rustc: error: the crate `bitflags` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind` error: aborting due to previous error error: the crate `bitflags` is compiled with the panic strategy `abort` which is incompatible with this crate's strategy of `unwind` error: aborting due to previous error error: Could not compile `gleam`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2060) <!-- Reviewable:end -->
|
With stable rustc, trying to build release + master of WR gives the compile errors above. I'm not really sure what changed to cause this - I haven't updated rustc, and I don't think any dependencies should have changed due to the Cargo.lock? Anyone with knowledge of this stuff explain (a) why this happened now (b) If this is a reasonable workaround for now (I don't think it will break Gecko?) (c) If there is a better fix? |
|
This is the last PR to merge, and it contains dependency updates #2032. So I guess that's what caused the build breakage, but I don't understand how that got through CI if that's the case... 😕 |
|
@bors-servo r- seeing fishy stuff locally |
|
Closing while we try to diagnose this a bit further. |
|
Running |
|
OK, as @gankro identified, this seems to be some kind of rustc / cargo bug - running |
error: the crate
bitflagsis compiled with the panic strategyabortwhich is incompatible with this crate's strategy ofunwinderror: aborting due to previous error
error: the crate
bitflagsis compiled with the panic strategyabortwhich is incompatible with this crate's strategy ofunwinderror: aborting due to previous error
error: Could not compile
gleam.This change is