Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: tidySupport option #31849

Merged
merged 1 commit into from Jul 23, 2018
Merged

php: tidySupport option #31849

merged 1 commit into from Jul 23, 2018

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Nov 20, 2017

Motivation for this change

I had something that needed the libtidy bindings in php, so I added this.

Things done

I only tested this in a very basic way: build and check phpinfo()

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Nov 20, 2017

@GrahamcOfBorg build php

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 20, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/bin/peardev: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
moving /nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/sbin/* to /nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11/bin
patching script interpreter paths in /nix/store/70bjq2a33knd3vp25ng415wzwy81cmsq-php-7.1.11-dev
/nix/store/vlyg8qls440lkxyxiiqdvwyxdnxayixn-php-7.1.11

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 20, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/bin/peardev: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
/nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
/nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
/nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-php-7.1.11.drv-0 in /nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11...
moving /nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/sbin/* to /nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/m0ar953fffyz9knbr48fckdhbdmq6dsp-php-7.1.11-dev
patching script interpreter paths in /nix/store/m0ar953fffyz9knbr48fckdhbdmq6dsp-php-7.1.11-dev
checking for references to /tmp/nix-build-php-7.1.11.drv-0 in /nix/store/m0ar953fffyz9knbr48fckdhbdmq6dsp-php-7.1.11-dev...
/nix/store/dqlakxs7ff29cvrxrnmhmv8ln9b28hly-php-7.1.11

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix merge conflicts

@elitak
Copy link
Contributor Author

elitak commented Jul 23, 2018

I've rebased this. @matthewbauer, can you re-review to unblock this? I can't recall what you requested in the changes, but I remember that I addressed it.

@matthewbauer
Copy link
Member

matthewbauer commented Jul 23, 2018 •
edited

@GrahamcOfBorg build php

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/8i8hqj3hg3axirbp7f990s1x50mnmq73-bash-4.4-p23/bin/sh"
/nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/8i8hqj3hg3axirbp7f990s1x50mnmq73-bash-4.4-p23/bin/sh"
/nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/8i8hqj3hg3axirbp7f990s1x50mnmq73-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7...
moving /nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7/sbin/* to /nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/dbglkjbwnxvfji6zp5f1d73qp71jiw9v-php-7.2.7-dev
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/dbglkjbwnxvfji6zp5f1d73qp71jiw9v-php-7.2.7-dev
checking for references to /build in /nix/store/dbglkjbwnxvfji6zp5f1d73qp71jiw9v-php-7.2.7-dev...
/nix/store/93yxka58l369rw2h1fik7ybk2dg4dqva-php-7.2.7

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php

Partial log (click to expand)

/nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/xlv8nwq2cbxm2yancb3yk3424ziyb91q-bash-4.4-p23/bin/sh"
/nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/xlv8nwq2cbxm2yancb3yk3424ziyb91q-bash-4.4-p23/bin/sh"
/nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/xlv8nwq2cbxm2yancb3yk3424ziyb91q-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7...
moving /nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7/sbin/* to /nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/nis9vb9qj1ygrs9ibf0fll16qk6bna7g-php-7.2.7-dev
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/nis9vb9qj1ygrs9ibf0fll16qk6bna7g-php-7.2.7-dev
checking for references to /build in /nix/store/nis9vb9qj1ygrs9ibf0fll16qk6bna7g-php-7.2.7-dev...
/nix/store/2ixijnda7dyr7dkdk432z3mclywsnjs5-php-7.2.7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: php

Partial log (click to expand)

/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/bin/pecl: interpreter directive changed from "/bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/6mhkwk1yvbrncacxk2zasvn4jzivpf3c-bash-4.4-p23/bin/sh"
moving /nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/sbin/* to /nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7/bin
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/wgys792d3ha1njw4vkfysrwrbyn2l3d1-php-7.2.7-dev
/nix/store/lw6jm5gg1rqpw70fwfkhcqxm3gncx3lv-php-7.2.7

@matthewbauer matthewbauer merged commit ca76620 into NixOS:master Jul 23, 2018
@elitak elitak deleted the tidySupport branch December 29, 2018 08:39
@elitak elitak restored the tidySupport branch December 29, 2018 08:40
@elitak elitak deleted the tidySupport branch December 29, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@matthewbauer matthewbauer matthewbauer requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elitak @fpletz @matthewbauer @GrahamcOfBorg