Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bash: mark inputrc etc file as default #31860

Merged
merged 1 commit into from Nov 21, 2017
Merged

nixos/bash: mark inputrc etc file as default #31860

merged 1 commit into from Nov 21, 2017

Conversation

rycee
Copy link
Member

@rycee rycee commented Nov 20, 2017 •
edited by grahamc

Motivation for this change

The bash module currently sets the /etc/inputrc unconditionally, which prevents easy user override. This commit lowers the priority of the setting to "option default" level, which allows a user to override
the value using either

environment.etc."inputrc".text = …

or

environment.etc."inputrc".source = …
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@rycee
nixos/bash: mark inputrc etc file as default
101d56c 
The bash module currently sets the `/etc/inputrc` unconditionally,
which prevents easy user override. This commit lowers the priority of
the setting to "option default" level, which allows a user to override
the value using either

    environment.etc."inputrc".text = …

or

    environment.etc."inputrc".source = …
@grahamc grahamc merged commit 3c9b356 into NixOS:master Nov 21, 2017
@rycee rycee deleted the nixos/bash/fix/inputrc branch November 21, 2017 09:14
@jfrankenau jfrankenau mentioned this pull request Aug 3, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rycee @grahamc @GrahamcOfBorg