Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-client: fix build after qt updates #31848

Closed
wants to merge 1 commit into from
Closed

nextcloud-client: fix build after qt updates #31848

wants to merge 1 commit into from

Conversation

averelld
Copy link
Contributor

Probably necessary after restructuring/updates in #31462

Motivation for this change

Missing Sql was the reason qt was downgraded in the first place: fdcb4fa
This fix might apply identically to owncloud-client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

nextcloud-client: fix build after qt updates
d84deff 
Probably necessary after restructuring/updates in NixOS#31462
@bjornfor
Copy link
Contributor

Applied to master (cce47a6). Thanks!

@bjornfor bjornfor closed this Nov 20, 2017
@averelld averelld deleted the nextcloud-client-qt-update branch November 20, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@averelld @bjornfor @GrahamcOfBorg @Janik-Haag