New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/mysql: add extraArguments option for mysqld #31675
Conversation
@@ -267,7 +276,7 @@ in | |||
chown -R ${cfg.user} /run/mysqld | |||
''; | |||
|
|||
serviceConfig.ExecStart = "${mysql}/bin/mysqld --defaults-extra-file=${myCnf} ${mysqldOptions}"; | |||
serviceConfig.ExecStart = "${mysql}/bin/mysqld --defaults-extra-file=${myCnf} ${mysqldOptions} ${concatStringsSep " " cfg.extraArguments}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should join the arguments using lib.escapeShellArgs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and useful!
Please also change concatStringsSep
to escapeShellArgs
:)
For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated
|
Thank you for your contributions.
|
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)