sharutils: simplify substituteInPlace syntax to be Nix 1.11.8 compatible #31676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build sharutils |
GrahamcOfBorg
approved these changes
Nov 15, 2017
There was a problem hiding this comment.
Success for system: x86_64-linux
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
5 5521k 5 287k 0 0 287k 0 0:00:19 --:--:-- 0:00:19 536k
100 5521k 100 5521k 0 0 5521k 0 0:00:01 0:00:01 --:--:-- 4290k
fetching path ‘/nix/store/d2xfak7ipf7jqmd2wn2xx315pb0l0p12-sharutils-4.15.2’...
*** Downloading ‘https://cache.nixos.org/nar/08yqcl576pfcrxmlwsk0hgc03kbb7l0igr8w10l42vcm75s25zl8.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/d2xfak7ipf7jqmd2wn2xx315pb0l0p12-sharutils-4.15.2’...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 239k 100 239k 0 0 239k 0 0:00:01 0:00:01 --:--:-- 164k
/nix/store/d2xfak7ipf7jqmd2wn2xx315pb0l0p12-sharutils-4.15.2
GrahamcOfBorg
approved these changes
Nov 15, 2017
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This expression isn't parsable by Nix 1.11.8 (16.09) and I think this change makes it nicer to read too?
cc @copumpkin
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)