Add reduce macromethod to TupleLiteral and ArrayLiteral #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Nov 15, 2017
Sija
reviewed
Nov 15, 2017
| end | ||
| end | ||
| else | ||
| raise "Only 0 or 1 args expected for reduce, got #{args.size}" |
There was a problem hiding this comment.
compile-time exceptions messages start with lowercase, like elsewhere.
RX14
requested changes
Nov 18, 2017
| when "reduce" | ||
| raise "reduce expects a block" unless block | ||
| accumulate_arg = block.args.first? | ||
| value_arg = block.args.size >= 2 ? block.args[1] : nil |
There was a problem hiding this comment.
🤙🏻
I will learn, eventually.
RX14
approved these changes
Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds a reduce macro method to
TupleLiteralandArrayLiteral.I'm not sure if there is a reason this was previously excluded, I couldn't find anything previous issues.