Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_4_14: fix iwlwifi fw reset #31678

Merged
merged 1 commit into from Nov 15, 2017
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2017

Currently, moving to kernel_4_14 breaks at least Intel Wireless 8260 and
8265 cards due to a API change in the firmware, which is not yet honored
in the driver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

Why do you commit the patch instead of fetching from https://bugzilla.kernel.org/attachment.cgi?id=260597&format=raw?

@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2017

Mostly because all other kernel patches are shipped in nixpkgs, too ;-)

But I'm also more in favor of using fetchpatch. PR updated.

@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

I think you should define the patch in pkgs/os-specific/linux/kernel/patches.nix and refer to it from all-packages.nix by name.

@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2017

updated.

Currently, moving to kernel_4_14 breaks at least Intel Wireless 8260 and
8265 cards due to a API change in the firmware, which is not yet honored
in the driver.
@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

Thank you!

@orivej orivej merged commit a7f4d97 into NixOS:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants