Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_4_14: fix iwlwifi fw reset #31678

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2017

Currently, moving to kernel_4_14 breaks at least Intel Wireless 8260 and
8265 cards due to a API change in the firmware, which is not yet honored
in the driver.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 101-500 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 15, 2017
@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

Why do you commit the patch instead of fetching from https://bugzilla.kernel.org/attachment.cgi?id=260597&format=raw?

@orivej orivej mentioned this pull request Nov 15, 2017
13 tasks
@flokli flokli force-pushed the fix-iwlwifi-linux-4.14 branch from c4d44c5 to f6c5f5a Compare November 15, 2017 03:40
@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2017

Mostly because all other kernel patches are shipped in nixpkgs, too ;-)

But I'm also more in favor of using fetchpatch. PR updated.

@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

I think you should define the patch in pkgs/os-specific/linux/kernel/patches.nix and refer to it from all-packages.nix by name.

@flokli flokli force-pushed the fix-iwlwifi-linux-4.14 branch from f6c5f5a to d5dcf90 Compare November 15, 2017 09:10
@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2017

updated.

Currently, moving to kernel_4_14 breaks at least Intel Wireless 8260 and
8265 cards due to a API change in the firmware, which is not yet honored
in the driver.
@orivej orivej force-pushed the fix-iwlwifi-linux-4.14 branch from d5dcf90 to f919c7f Compare November 15, 2017 11:30
@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

Thank you!

@orivej orivej merged commit a7f4d97 into NixOS:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants