Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtetrinet: init at 0.7.11 #31688

Merged
merged 1 commit into from Nov 15, 2017
Merged

Conversation

chris-martin
Copy link
Contributor

@chris-martin chris-martin commented Nov 15, 2017

Motivation for this change

This was a great old game

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member

builds fine and runs! merging! thanks for the contribution!

@chris-martin chris-martin deleted the pr/gtetrinet branch November 15, 2017 04:54
@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

This needs export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 to prevent a wall of warnings during install. I've commited that and various style fixes in 3dded41.

I expect the authors of pull requests to explain why git revision is not the tag with the version, especially when it differs from the tag with the version; but in this case it seems somewhat acceptable.

@chris-martin
Copy link
Contributor Author

chris-martin commented Nov 16, 2017

I expect the authors of pull requests to explain why git revision is not the tag with the version, especially when it differs from the tag with the version; but in this case it seems somewhat acceptable.

For posterity: The reason is because gtetrinet hasn't been actively maintained since about a decade ago, and some fixes we need (like https://github.com/GNOME/gtetrinet/commit/717dc612a884011ec1c0e838db1c9c51b9e533c6) happened in the last few years but never made it into a new release version.

@chris-martin
Copy link
Contributor Author

@orivej I put a line break in the argument list because the manual says

Function formal arguments are written as:

{ arg1, arg2, arg3 }:

but if they don't fit on one line they're written as:

{ arg1, arg2, arg3
, arg4, ...
, # Some comment...
  argN
}:

It doesn't say how many characters consistutes "one line," so I guessed 80. Is that wrong? I'll PR to update the docs if I can find out what the correct style is.

@orivej
Copy link
Contributor

orivej commented Nov 16, 2017

Your indentation was fine, but I removed some dependencies and the list got shorter. (Some dependencies are subsumed by autoreconfHook, perl is an internal dependency of intltool and is not directly used by gtetrinet.)

@chris-martin
Copy link
Contributor Author

Ah yes, sorry I misread.

Regarding the warning output, would you mind explaining why it matters (and should we mention that in the manual, perhaps in the Contributing guide?), and how did you know to set the GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL variable to fix it?

@orivej
Copy link
Contributor

orivej commented Nov 16, 2017

The warnings are just inconvenient: for example, if someone changes a dependency of gtetrinet and tests all affected packages with nox-review, they may waste some time to check if the warnings are relevant or not, because they are very prominent; and they make any previous output hard to read, because they quickly scroll it away.

I've looked for how other packages deal with grome2.GConf (maybe there is a way to actually install the schemas to avoid the warnings?) and found this variable used here:

# Configuring the installation to not install gconf schemas is not always supported,
# therefore gconftool-2 has this variable, which will make gconftool-2 not update any of the databases.
"GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants