New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtetrinet: init at 0.7.11 #31688
gtetrinet: init at 0.7.11 #31688
Conversation
builds fine and runs! merging! thanks for the contribution! |
This needs I expect the authors of pull requests to explain why git revision is not the tag with the version, especially when it differs from the tag with the version; but in this case it seems somewhat acceptable. |
For posterity: The reason is because gtetrinet hasn't been actively maintained since about a decade ago, and some fixes we need (like https://github.com/GNOME/gtetrinet/commit/717dc612a884011ec1c0e838db1c9c51b9e533c6) happened in the last few years but never made it into a new release version. |
@orivej I put a line break in the argument list because the manual says
It doesn't say how many characters consistutes "one line," so I guessed 80. Is that wrong? I'll PR to update the docs if I can find out what the correct style is. |
Your indentation was fine, but I removed some dependencies and the list got shorter. (Some dependencies are subsumed by autoreconfHook, perl is an internal dependency of intltool and is not directly used by gtetrinet.) |
Ah yes, sorry I misread. Regarding the warning output, would you mind explaining why it matters (and should we mention that in the manual, perhaps in the Contributing guide?), and how did you know to set the |
The warnings are just inconvenient: for example, if someone changes a dependency of gtetrinet and tests all affected packages with nox-review, they may waste some time to check if the warnings are relevant or not, because they are very prominent; and they make any previous output hard to read, because they quickly scroll it away. I've looked for how other packages deal with grome2.GConf (maybe there is a way to actually install the schemas to avoid the warnings?) and found this variable used here: nixpkgs/pkgs/applications/misc/guake/default.nix Lines 50 to 52 in ef0486b
|
Motivation for this change
This was a great old game
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)