Fix ASTNode#to_s to wrap with parenthesis as needed #5222
Closed
+59
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5219
Whether current
ASTNode#to_s
wrapExpressions
with parenthesis (or begin/end) is depending on the parent of this. And default wrapping policy is no wrapping. It causes some problems, for example #5219 or see this:Expected output is
false
of course but this program printstrue
currently, because{% debug() %}
output is:So parenthesis is disappeared and program is broken.
I fixed
ASTNode#to_s
to wrap parenthesis in every time except thisExpressions
wants indent.