Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing performance tweaks #633

Merged
merged 1 commit into from Nov 14, 2017

Conversation

phit
Copy link
Contributor

@phit phit commented Nov 1, 2017

Added missing tweaks, changed indentation for all code blocks to be the same, and updated the code blocks (copied from a fresh 1.11.2 global.conf).

Not quite happy with the realtime explanation myself, feel free add comments to it and I'll update.

Closes #482

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that you dont exceed the 120 chars per line.

Realtime
========

Enabling this will not actually improve performance, but instead will improve your experience a lot when tick rate is low. A limited set of entities, tile entities and world time will use real time instead of ticks to update.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newlines to avoid overly long lines in the editor. 120chars max.

realtime=false
}

One example of this is baby animals. Normally, they take 20 minutes to grow into an adult. However, if the server is lagging, each animal will receive fewer ticks thus increasing the time they take to grow up. This setting updates some of their logic to use the actual elapsed wall-clock time, rather than number of ticks. It will also apply to block breaking, so no more "breaking blocks multiple times".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newlines to avoid overly long lines in the editor. 120chars max.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ done

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant do an in depth check for now, but it looks good to me.

Realtime
========

Enabling this will not actually improve performance, but instead will improve your experience a lot when tick rate is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should start with what it does, and leave what it does not do to the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ST-DDT
Copy link
Member

ST-DDT commented Nov 12, 2017

@Inscrutable All concerns addressed?

@Inscrutable Inscrutable merged commit 1bf9880 into SpongePowered:stable Nov 14, 2017
@phit phit deleted the feature/perf-patches branch January 7, 2018 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants