Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hardlink: 2012.9.3ec908d539 --> 1.3-4 #31091

Merged
merged 1 commit into from Nov 2, 2017
Merged

hardlink: 2012.9.3ec908d539 --> 1.3-4 #31091

merged 1 commit into from Nov 2, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 1, 2017 •
edited

Motivation for this change

Current version in the nixpkgs tree is quite old
Also homepage is updated as per #30636

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b requested a review from nbp as a code owner November 1, 2017 14:12
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 1, 2017 

=== Reviewing PR 31091 : hardlink: 2012.9.3ec908d539 --> 1.3-4
==> Fetching base (master)
==> Fetching PR
==> Fetching extra history for merging
==> Merging PR into base
Building in /run/user/1000/nox-review-7vn4avng: hardlink
Invoking nix-build -A hardlink /home/demo/.nox/nixpkgs
[...]
/nix/store/ycy3bbzrk6sxskrfcps0c983mf4k3q1w-hardlink-1.3-4
Result in /run/user/1000/nox-review-7vn4avng
total 0
lrwxrwxrwx 1 demo users 58  1 nov.  15:16 result -> /nix/store/ycy3bbzrk6sxskrfcps0c983mf4k3q1w-hardlink-1.3-4

@Mic92 Mic92 merged commit 455ab9f into NixOS:master Nov 2, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Thanks!

@c0bw3b c0bw3b deleted the pkg/hardlink branch November 2, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @Mic92 @GrahamcOfBorg