Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack: 2.8.0 -> 2.8.2 (potential electron security update) #31078

Merged
merged 1 commit into from Nov 1, 2017

Conversation

andir
Copy link
Member

@andir andir commented Nov 1, 2017

fixes japanese input & some obscure security issues:
An important Electron update improving security. A precautionary measure, but it’s always good to be up to date. and
A small release containing nothing but another Electron update, this one better than the last.

Release notes at: https://slack.com/intl/en-en/release-notes/linux

One might consider backporting this to stable due to the potential security fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

fixes japanese input & some obscure security issues:
`An important Electron update improving security. A precautionary measure, but it’s always good to be up to date.` and
`A small release containing nothing but another Electron update, this one better than the last.`
@globin globin merged commit a243739 into NixOS:master Nov 1, 2017
@globin
Copy link
Member

globin commented Nov 1, 2017

Backported to 17.09 in 20088e3

@andir andir deleted the slack-2.8.2 branch November 22, 2017 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants