nixos-prepare-root: chmod if dir already exists, fixes #22413 #31071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukateras
changed the title
copumpkin
reviewed
Nov 1, 2017
| shift | ||
|
|
||
| for dir in $@; do | ||
| if [ -d "$dir" ]; then |
Mic92
reviewed
Nov 2, 2017
| mkdir -m 01777 -p $mountPoint/tmp | ||
| mkdir -m 0755 -p $mountPoint/tmp/root | ||
| mkdir -m 0755 -p $mountPoint/var | ||
| mkdir -m 0700 -p $mountPoint/root |
There was a problem hiding this comment.
I think the install command does both creating a directory and change permission in one shot.
There was a problem hiding this comment.
You are right, install -d does that.
lukateras
force-pushed
the
nixos-install/mkdir-or-chmod
branch
from
186a0d1
to
2c9e195
Compare
|
Switched to |
|
we have |
|
Looks good to me if the tests pass 👍 |
|
NixOS installer tests pass. Thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #22413. Please note that while I have tested the new
setupDirfunction separately, I haven't testednixos-installornixos-prepare-root, so testing is appreciated!Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)