Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: 5.4.0 -> 5.5.0 #31088

Merged
merged 1 commit into from Nov 2, 2017
Merged

gcc: 5.4.0 -> 5.5.0 #31088

merged 1 commit into from Nov 2, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 1, 2017 •
edited by grahamc

Use this as an opportunity to remove empty patches array.

Motivation for this change

Minor update.
Includes fix particularly relevant for Nix users where large PATH entries overflowed the stack and badness resulted:
https://git.musl-libc.org/cgit/musl/commit/?id=004dc9549b8003288e635ba5aa91e3353e1974c4
The commit author is also super cool 馃槆.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Checked nix-build pkgs/stdenv/linux/make-bootstrap-tools.nix -A test

@dtzWill
gcc: 5.4.0 -> 5.5.0
a4d5586 
Switch to xz since there is no bz2 variant (apparently)
@dtzWill dtzWill requested a review from nbp as a code owner November 1, 2017 13:41
@copumpkin
Copy link
Member

This should probably go against staging since it's a mass rebuild

@copumpkin
Copy link
Member

Oh wait, the default stdenv is on gcc6 now, so maybe not?

@grahamc
Copy link
Member

grahamc commented Nov 1, 2017

... we'll find out soon ...

@orivej
Copy link
Contributor

orivej commented Nov 1, 2017 •
edited

This rebuilds just 38 packages, but dmd is one of them and at the moment it can not be tested: #31004 (comment)

@orivej orivej mentioned this pull request Nov 1, 2017
Merged
8 tasks
@orivej
Copy link
Contributor

orivej commented Nov 2, 2017

@pbogdan has fixed the build of dmd (#31132) and nox-review has built this pull request. Thank you!

@orivej orivej merged commit 473b1e3 into NixOS:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @copumpkin @grahamc @orivej @GrahamcOfBorg