iwona (font): init at 0_995 #31067
Merged
iwona (font): init at 0_995 #31067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just out of curiosity, can someone clarify what the flags that have been added to this issue mean? |
|
@siddharthist it means it affects rebuilds of no more than 10 packages. |
disassembler
reviewed
Nov 1, 2017
| meta = with stdenv.lib; { | ||
| description = "A two-element sans-serif typeface, created by Małgorzata Budyta"; | ||
| homepage = http://jmn.pl/en/kurier-i-iwona/; | ||
| # "[...] GUST Font License (GFL), which is a free license, legally |
There was a problem hiding this comment.
I don't think we need this particular comment above the license. If they say it's legally equivalent, I think we can use the lppl you are using.
There was a problem hiding this comment.
Somebody stumble over the difference, so I would keep the remark also there is technically no difference.
c0bw3b
reviewed
Nov 1, 2017
pkgs/data/fonts/iwona/default.nix
Outdated
| version = "0_995"; | ||
|
|
||
| src = fetchzip { | ||
| url = "jmn.pl/pliki/Iwona-otf-${version}.zip"; |
There was a problem hiding this comment.
Maybe you should explicitly specify http:// protocol here for clarity ?
|
Thanks for the reviews, and special thanks to @Mic92 for fixing it up! I'm glad to learn about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Another great sans-serif font!
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)