utox: 0.13.1 -> 0.16.1 #31072
Merged
utox: 0.13.1 -> 0.16.1 #31072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
reviewed
Nov 2, 2017
| }; | ||
|
|
||
| buildInputs = [ | ||
| libtoxcore dbus libvpx libX11 openal freetype | ||
| libv4l libXrender fontconfig libXext libXft filter-audio | ||
| libsodium | ||
| libsodium libopus check |
There was a problem hiding this comment.
I am assuming that check is for the checkPhase. Can we add it to checkInputs instead then? Alternatively, nativeBuildInputs.
There was a problem hiding this comment.
I think checkInputs only exists in buildPythonPackage.
There was a problem hiding this comment.
I think you're right @Mic92 - always nice to learn something new.
In that case it should be nativeBuildInputs.
There was a problem hiding this comment.
Good point. I've moved "check" to nativeBuildInputs, and added an appropriatecheckTarget configuration.
Moved 'check' to nativeBuildInputs, as it is only used by the tests
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updated to latest upstream version.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)