osx_private_sdk: reduce output size and remove it from runtime closures #31086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thanks!! This isn't a mass rebuild, right? |
|
It'd guess it's 100-500 rebuilds, but let's wait on @grahamc bot :-) |
domenkozar
force-pushed
the
osx_private_sdk_remove_runtime
branch
from
8661bd0
to
98642ce
Compare
|
|
Do we need a larger bucket than 500+?
…On Thu, Nov 2, 2017 at 09:56 Daiderd Jordan ***@***.***> wrote:
Estimating rebuild amount by counting changed Hydra jobs.
2011 x86_64-darwin
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31086 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAErrCg-U3MMZ854vUblVtyT6bEANvgyks5syYPFgaJpZM4QOLGv>
.
|
|
why doesn't bot just comment the exact numbers? It would be as annoying as mention bot and people can add it to ignore list |
|
@grahamc maybe bot could publish a gist for status check :) but you probably already have it planned :) |
|
@grahamc I just didn't notice the bot added the labels before posting. Don't know if another label would be useful, but 500-20k is a pretty big gap 😄 |
|
Anyway, it might make sense to send this to staging, especially with Hydra acting up as it has been recently. Otherwise it looks great! |
domenkozar
force-pushed
the
osx_private_sdk_remove_runtime
branch
from
98642ce
to
5456ab7
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osx_private_sdkoutput size from 350MB to 0.5MB