jupyterhub - the sequel #31950
jupyterhub - the sequel #31950
Conversation
| @@ -10042,6 +10048,8 @@ in { | |||
|
|
|||
| jupyter_core = callPackage ../development/python-modules/jupyter_core { }; | |||
|
|
|||
| jupyterhub = callPackage ../development/python-modules/jupyterhub { }; | |||
There was a problem hiding this comment.
I don't think this should be in pythonPackages (or python-modules). Since it provides a binary to run, I think this should be a separate application in top-level
There was a problem hiding this comment.
Yes and no, its a bit tricky. The jupyterhub and the notebook are applications, and could/should be outside of python-packages.nix, but notebook needs a kernel and that one needs to be inside python-packages.nix. Doing it that way requires a bit more setup to get e.g. a Python 3 kernel with a Python 2 notebook, so this is a more pragmatic solution. In the long-term I think we should go in that direction, providing a function that allows you to add kernels to your notebook.
| traitlets | ||
| ]; | ||
|
|
||
| # Disable tests because they take an excessive amount of time to complete. |
There was a problem hiding this comment.
How long is an excessive amount of time?
There was a problem hiding this comment.
I let it run for about 20 minutes. The build logs showed that some routes were being hit, so presumably the tests were running (because what else could be making requests within the build environment?). At 20 minutes in, and with a mere 5 or 6 lines of "GET / [... blah ...]" in the build log, I gave up on waiting. I don't know what the tests were doing, but they seemed to be doing it a glacial pace.
|
@disassembler - are the changes in your review still requested or do you agree with @FRidh? |
|
This PR has to resolve conflicts with the master branch. |
|
@disassembler, @FRidh, @orivej - I merged this PR back into mine (#31871) and made the requested changes. |
|
#31871 was merged and took the changes from this one so this PR can be closed |
Motivation for this change
@ixxie got
jupyterhub99% packaged in #31871; this just puts the finishing touches in place.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)