simp_le: 0.6.1 -> 0.6.2 #31944
Closed
simp_le: 0.6.1 -> 0.6.2 #31944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the changelog, this release of simp_le will be future-proof by not hard-coding the TOS checksum
|
cc @fpletz |
|
should we back port this? |
Mic92
added
the
9.needs: port to stable
|
@GrahamcOfBorg build simp_le |
There was a problem hiding this comment.
Success for system: x86_64-linux
patching script interpreter paths in /nix/store/v0ljjrmgjnkvam6zkn45673029ia89f7-simp_le-client-0.6.2
checking for references to /tmp/nix-build-simp_le-client-0.6.2.drv-0 in /nix/store/v0ljjrmgjnkvam6zkn45673029ia89f7-simp_le-client-0.6.2...
wrapping `/nix/store/v0ljjrmgjnkvam6zkn45673029ia89f7-simp_le-client-0.6.2/bin/simp_le'...
running install tests
...............................
----------------------------------------------------------------------
Ran 31 tests in 0.484s
OK
/nix/store/v0ljjrmgjnkvam6zkn45673029ia89f7-simp_le-client-0.6.2
|
I agree it should go to stable. I'm happy to merge and backport, but would like @fpletz confirmation. |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
raise Error('Failed to execute external script: %s' % error)
Error: Failed to execute external script: [Errno 8] Exec format error
----------------------------------------------------------------------
Ran 31 tests in 1.871s
FAILED (errors=1)
builder for '/nix/store/fw04dx00vxyqy5pd0iqdppq61d49p469-simp_le-client-0.6.2.drv' failed with exit code 2
error: build of '/nix/store/fw04dx00vxyqy5pd0iqdppq61d49p469-simp_le-client-0.6.2.drv' failed on ‘mac1’
error: build of ‘/nix/store/fw04dx00vxyqy5pd0iqdppq61d49p469-simp_le-client-0.6.2.drv’ failed
domenkozar
approved these changes
Nov 23, 2017
|
I believe this should have been merged a long time ago? |
dotlambda
reviewed
Mar 20, 2018
| @@ -2,12 +2,12 @@ | |||
|
|
|||
| pythonPackages.buildPythonApplication rec { | |||
| pname = "simp_le-client"; | |||
| version = "0.6.1"; | |||
| version = "0.6.2"; | |||
| name = "${pname}-${version}"; | |||
|
However, there is now version 0.8. |
|
i am pretty sure that |
|
too many changes required, i will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
according to the changelog, this release of simp_le will be
future-proof by not hard-coding the TOS checksum.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)