Skip to content

libc++ version and removal of 32-bit support #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2017

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Nov 22, 2017

Fix #1627.

@@ -24,13 +24,12 @@ internal static class Loader {
switch (Environment.OSVersion.Platform) {
case PlatformID.Win32NT:
can_determine_cxx_installed = true;
is_cxx_installed = () => IsVCRedistInstalled(is_32_bit);
is_cxx_installed = () => IsVCRedistInstalled();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does is_cxx_installed = IsVCRedistInstalled; work?

@eggrobin eggrobin added the LGTM label Nov 22, 2017

Verified

This commit was signed with the committer’s verified signature.
jtojnar Jan Tojnar
@pleroy pleroy merged commit cbd5cf2 into mockingbirdnest:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants