Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-mgmt.xml: extraUsers => users #31941

Merged
merged 1 commit into from
Nov 23, 2017
Merged

user-mgmt.xml: extraUsers => users #31941

merged 1 commit into from
Nov 23, 2017

Conversation

Rovanion
Copy link
Contributor

Motivation for this change

According to #nixos@freenode these are the proper names for these configuration settings.

Things done

Changed extraUsers => users and extraGroups => groups in nixos manual chapter 7.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 22, 2017
@Rovanion
Copy link
Contributor Author

Heads up: users.users.<user>.groups does not seem to be a thing in 17.09. Does anyone know if it exists on master or if I should remove those changes from the commit.

@FRidh FRidh added 8.has: documentation This PR adds or changes documentation 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Nov 22, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 22, 2017

seems to be an alias introduced 2 years ago: 14321ae

{ isNormalUser = true;
home = "/home/alice";
description = "Alice Foobar";
extraGroups = [ "wheel" "networkmanager" ];
groups = [ "wheel" "networkmanager" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is actually not valid.

@@ -54,7 +54,7 @@ to the user specification.</para>
group named <literal>students</literal> shall exist:

<programlisting>
users.extraGroups.students.gid = 1000;
users.groups.students.gid = 1000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok.

Changed extraUsers -> users and one case of extraGroups -> groups in nixos manual chapter 7.

According to chatter on IRC these are the proper names for these configuration options nowadays.

Modified based on feedback from Jörg Talheim.
@Rovanion
Copy link
Contributor Author

I've now modified the commit based on the feedback of @Mic92.

@Rovanion Rovanion changed the title user-mgmt.xml: extraUsers => users and extraGroups => groups user-mgmt.xml: extraUsers => users Nov 23, 2017
@Mic92 Mic92 merged commit d541d0c into NixOS:master Nov 23, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 23, 2017

Thanks!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants