docker & docker-machine-xhyve: enable darwin support #31737

periklis · 2017-11-16T11:53:22Z

Motivation for this change

Using docker cli client as a pure dependency on darwin is the starting point for a more pure docker support on this platform. The proposed PR makes docker-engine builds depending on platform. This is not a full docker support for darwin, because running the daemon needs either a virtualbox or xhyve based solution.

This packages:

docker cli
docker-machine-xhyve

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

NeQuissimus · 2017-11-16T13:14:48Z

For the heck of it, could you (outside this PR) try Docker v17.11.0-ce-rc4 ?
Might as well make the implementation work with the soon-to-be-released 17.11

periklis · 2017-11-16T13:27:46Z

@NeQuissimus sure, why not :)

periklis · 2017-11-16T14:24:23Z

@NeQuissimus The darwin build for v17.11.0-ce-rc4 works fine. However, i do not have access to a hydra for linux builds. I can push a second branch for that.

NeQuissimus · 2017-11-16T15:23:25Z

No, no worries, I just wanted to make sure since I usually only test Docker on Linux when I update

LnL7 · 2017-11-16T21:39:21Z

@GrahamcOfBorg build docker

GrahamcOfBorg

Failure for system: x86_64-linux


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

GrahamcOfBorg

Failure for system: x86_64-darwin


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

NeQuissimus · 2017-11-17T21:36:00Z

@grahamc What happened to the borg here?

grahamc · 2017-11-17T21:40:02Z

I just re-triggered evaluation checking again. Are you wondering about the build results or the eval results?

NeQuissimus · 2017-11-17T21:40:23Z

Docker should not be marked as broken...

grahamc · 2017-11-17T21:42:31Z

It turns out all the errors here are from the same problem. something about this PR makes this happen:

error: Package ‘docker-17.09.0-ce’ in /var/lib/gc-of-borg/.nix-test/mr-est-38dca4e3aa6bca43ea96d2fcc04e8229-31737/pkgs/applications/virtualization/docker/default.nix:190 is not supported on ‘x86_64-linux’, refusing to evaluate.

NeQuissimus · 2017-11-17T21:43:48Z

Oh!

Could we get @GrahamcOfBorg to output this info somehow?

grahamc · 2017-11-17T21:44:56Z

I've been thinking through this a bit. I think yes, I'm a bit worried about sharing secrets about hosts but I think with our Hydra-like safeguards, we should be OK to share them.

Actually doing so is another thing. Can you open an issue on grahamc/ofborg ?

periklis · 2017-11-20T08:00:05Z

@NeQuissimus Packaging docker-machine-xhyve will take me some time. However we can merge this for start to enable using docker cli als buildInput on darwin.

periklis · 2017-11-20T08:01:01Z

@grahamc Can anybody call for Grahamcofborg to build our PR or maintainers only?

LnL7 · 2017-11-20T11:47:35Z

@GrahamcOfBorg build docker

GrahamcOfBorg

Failure for system: x86_64-darwin


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

GrahamcOfBorg

Failure for system: x86_64-linux


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

grahamc · 2017-11-20T12:44:57Z

@periklis only about 10 people can call it right now. We're working on making it a wider group though!

grahamc · 2017-11-20T12:45:58Z

Note, though, that it doesn't make sense that Docker is broken on Linux here. Something is wrong with this PR.

periklis · 2017-11-20T13:18:11Z

@grahamc Sure it doesn't make sense to merge something broken. However, if borg is not giving me an useful error message, could somebody put a simple jobset on hydra to find the issue?

grahamc · 2017-11-20T13:32:31Z

I've posted the error message, and the bot has posted the same error message, also see the "Details" link next to "eval-nixos-options" (this is new as of Yesterday.) Hydra won't tell us more, unfortunately.

NeQuissimus · 2017-11-20T14:17:26Z

@periklis This is literally all we have to go on:

(Docker definitely builds on master, not with this PR; I just tried both)

λ nix-build -A docker --show-trace
error: while evaluating the attribute ‘docker_17_09’ at /home/nequi/dev/nixpkgs/pkgs/applications/virtualization/docker/default.nix:200:3:
while evaluating ‘dockerGen’ at /home/nequi/dev/nixpkgs/pkgs/applications/virtualization/docker/default.nix:11:15, called from /home/nequi/dev/nixpkgs/pkgs/applications/virtualization/docker/default.nix:200:18:
while evaluating ‘mkDerivation’ at /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:15:5, called from /home/nequi/dev/nixpkgs/pkgs/applications/virtualization/docker/default.nix:16:7:
while evaluating ‘addPassthru’ at /home/nequi/dev/nixpkgs/lib/customisation.nix:135:22, called from /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:166:7:
while evaluating anonymous function at /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/check-meta.nix:5:1, called from /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:167:22:
while evaluating ‘throwEvalHelp’ at /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/check-meta.nix:128:19, called from /home/nequi/dev/nixpkgs/pkgs/stdenv/generic/check-meta.nix:194:17:
Package ‘docker-17.09.0-ce’ in /home/nequi/dev/nixpkgs/pkgs/applications/virtualization/docker/default.nix:190 is not supported on ‘x86_64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

NeQuissimus · 2017-11-20T15:30:37Z

@periklis I am still getting the same error

LnL7

I suspect you have allowBroken = true; in your config.nix that hides the meta problem on your machine. In that case you can use --argstr config {} or :a import <nixpkgs> { config = {}; } in nix-repl for testing to make sure your local config/overrides don't influence the results.

LnL7 · 2017-11-20T18:54:45Z

pkgs/applications/virtualization/docker/default.nix

-      maintainers = with maintainers; [ nequissimus offline tailhook vdemeester ];
-      platforms = platforms.linux;
+      maintainers = with maintainers; [ nequissimus offline tailhook vdemeester periklis ];
+      platforms = with platforms; [ linux darwin ];


this is causing the evaluation errors, things in stdenv.lib.platforms are already lists because some attributes contain multiple architectures.

LnL7 · 2017-11-20T19:17:50Z

@GrahamcOfBorg build docker

GrahamcOfBorg

Failure for system: x86_64-linux


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

GrahamcOfBorg

Failure for system: x86_64-darwin


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use ‘--show-trace’ to show detailed location information)

periklis · 2017-11-20T19:29:19Z

just for the protocol from the irc, the instantiation of the derivation on x86_64-linux is fine:
nix-instantiate -A docker --show-trace --argstr system 'x86_64-linux'
However, the borg uses the extra option --option restrict-eval true.

The error was in with.platforms; linux ++ darwin; vs. with.platforms; [ linux darwin ], where latter is [["x86_64-linux" "i686-linux"] ["x86_64-darwin"]]

LnL7 · 2017-11-20T19:35:38Z

@GrahamcOfBorg build docker

GrahamcOfBorg

Success for system: x86_64-darwin

2017/11/20 20:08:00 WARN: man/src/system/prune.md does not exist, skipping
2017/11/20 20:08:00 WARN: man/src/system.md does not exist, skipping
2017/11/20 20:08:00 WARN: man/src/volume/prune.md does not exist, skipping
2017/11/20 20:08:00 WARN: man/src/volume/rm.md does not exist, skipping
Generate legacy manpages
post-installation fixup
patching script interpreter paths in /nix/store/wj9ffr61i0dkxwk3yj88q1wyq23hpm1k-docker-17.09.0-ce
gzipping man pages under /nix/store/ih418srgyhp4j97g7h3npdwlm66x36d3-docker-17.09.0-ce-man/share/man/
patching script interpreter paths in /nix/store/ih418srgyhp4j97g7h3npdwlm66x36d3-docker-17.09.0-ce-man
/nix/store/wj9ffr61i0dkxwk3yj88q1wyq23hpm1k-docker-17.09.0-ce

GrahamcOfBorg

Success for system: x86_64-linux

shrinking RPATHs of ELF executables and libraries in /nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce
shrinking /nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce/libexec/docker/docker
shrinking /nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce/libexec/docker/dockerd
patching script interpreter paths in /nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce
checking for references to /tmp/nix-build-docker-17.09.0-ce.drv-0 in /nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce...
shrinking RPATHs of ELF executables and libraries in /nix/store/jb688pnw1m9lx69qc3a9w0w4xqvgincz-docker-17.09.0-ce-man
gzipping man pages under /nix/store/jb688pnw1m9lx69qc3a9w0w4xqvgincz-docker-17.09.0-ce-man/share/man/
patching script interpreter paths in /nix/store/jb688pnw1m9lx69qc3a9w0w4xqvgincz-docker-17.09.0-ce-man
checking for references to /tmp/nix-build-docker-17.09.0-ce.drv-0 in /nix/store/jb688pnw1m9lx69qc3a9w0w4xqvgincz-docker-17.09.0-ce-man...
/nix/store/qdn6f8g5faq5xknkvi2kljf25nrb96rb-docker-17.09.0-ce

NeQuissimus · 2017-11-20T20:11:35Z

Ah, I missed that! Makes sense now... I think this is good to go then?!

periklis · 2017-11-20T20:12:56Z

@NeQuissimus yes let's wait for the borg builds and then i'll push the squashed commits with the fixups.

NeQuissimus · 2017-11-20T20:14:16Z

I think everything has been built, no?

LnL7 · 2017-11-20T20:15:22Z

was waiting for the eval checks

gilligan · 2017-11-20T20:17:32Z

Is there any documentation that could/should be written for this?

NeQuissimus · 2017-11-20T20:18:10Z

I guess we're not squashing? :D Anyways, things should work fine now

periklis · 2017-11-20T20:21:31Z

@gilligan it can be used like this: https://pewpewthespells.com/blog/setup_docker_on_mac.html

gilligan · 2017-11-20T21:29:11Z

@periklis that’s not documentation though, that is a link to a blog article talking about homebrew stuff ;)

I was wondering if smth could/should be added to the manual about using this.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 16, 2017

LnL7 added the 6.topic: darwin Running or building packages on Darwin label Nov 16, 2017

periklis force-pushed the init-docker-darwin-support branch from bd20383 to 1b5b157 Compare November 17, 2017 09:12

GrahamcOfBorg reviewed Nov 17, 2017

View reviewed changes

NeQuissimus mentioned this pull request Nov 17, 2017

Evaluation errors NixOS/ofborg#4

Closed

periklis changed the title ~~WIP docker: enable darwin support~~ docker cli: enable darwin support Nov 20, 2017

GrahamcOfBorg reviewed Nov 20, 2017

View reviewed changes

periklis force-pushed the init-docker-darwin-support branch from 1b5b157 to 594ad44 Compare November 20, 2017 14:24

periklis added 2 commits November 20, 2017 20:07

docker-cli: enable darwin support

0f0ffa7

docker-machine-xhyve: init darwin support

73c9152

periklis force-pushed the init-docker-darwin-support branch from 594ad44 to 73c9152 Compare November 20, 2017 19:07

periklis changed the title ~~docker cli: enable darwin support~~ docker & docker-machine-xhyve: enable darwin support Nov 20, 2017

LnL7 reviewed Nov 20, 2017

View reviewed changes

fixup! docker-cli: enable darwin support

4a2bd8e

GrahamcOfBorg reviewed Nov 20, 2017

View reviewed changes

fixup! docker-cli: enable darwin support

1434c5e

GrahamcOfBorg reviewed Nov 20, 2017

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 20, 2017

LnL7 approved these changes Nov 20, 2017

View reviewed changes

LnL7 merged commit a6172a9 into NixOS:master Nov 20, 2017

periklis deleted the init-docker-darwin-support branch November 20, 2017 20:21

docker & docker-machine-xhyve: enable darwin support #31737

docker & docker-machine-xhyve: enable darwin support #31737

Conversation

periklis commented Nov 16, 2017 • edited

Motivation for this change

Things done

NeQuissimus commented Nov 16, 2017

periklis commented Nov 16, 2017

periklis commented Nov 16, 2017

NeQuissimus commented Nov 16, 2017

LnL7 commented Nov 16, 2017 • edited

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

NeQuissimus commented Nov 17, 2017

grahamc commented Nov 17, 2017

NeQuissimus commented Nov 17, 2017

grahamc commented Nov 17, 2017

NeQuissimus commented Nov 17, 2017

grahamc commented Nov 17, 2017 • edited

periklis commented Nov 20, 2017

periklis commented Nov 20, 2017

LnL7 commented Nov 20, 2017 • edited

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

grahamc commented Nov 20, 2017

grahamc commented Nov 20, 2017

periklis commented Nov 20, 2017

grahamc commented Nov 20, 2017

NeQuissimus commented Nov 20, 2017

NeQuissimus commented Nov 20, 2017

LnL7 left a comment

Choose a reason for hiding this comment

LnL7 Nov 20, 2017

Choose a reason for hiding this comment

LnL7 commented Nov 20, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

periklis commented Nov 20, 2017 • edited

LnL7 commented Nov 20, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

NeQuissimus commented Nov 20, 2017

periklis commented Nov 20, 2017

NeQuissimus commented Nov 20, 2017

LnL7 commented Nov 20, 2017

gilligan commented Nov 20, 2017

NeQuissimus commented Nov 20, 2017

periklis commented Nov 20, 2017

gilligan commented Nov 20, 2017

periklis commented Nov 16, 2017 •

edited

LnL7 commented Nov 16, 2017 •

edited

grahamc commented Nov 17, 2017 •

edited

LnL7 commented Nov 20, 2017 •

edited

periklis commented Nov 20, 2017 •

edited