rambox: allow user to use other auth0 credentials #31730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
approved these changes
Nov 17, 2017
lukateras
approved these changes
Nov 17, 2017
ghost
deleted the
Mic92
reviewed
Oct 21, 2018
| # for another distribution, go to https://auth0.com. If you want to reuse the same | ||
| # domain, drop a line at yegortimoshenko@gmail.com! | ||
| , auth0ClientID ? "0spuNKfIGeLAQ_Iki9t3fGxbfJl3k8SU" | ||
| , auth0Domain ? "nixpkgs.auth0.com" }: |
There was a problem hiding this comment.
@yegortimoshenko
I get:
Callback URL mismatch.
The URL "https://nixpkgs.auth0.com/mobile" is not in the list of allowed callback URLs.
Please go to the Application Settings page and make sure you are sending a valid callback url from your application.
now when I login.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow user to override auth0 credentials, because accounts and user data are not shared accross domains, so for example I can't use the account I've registered via official binary Rambox build.
Additionally it's a privacy measure, since one who owns the auth0 domain can admin registered user accounts, so user may prefer to register an own credentials.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)