joker: init at 0.8.6 #30942
Merged
joker: init at 0.8.6 #30942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
suggested changes
Oct 30, 2017
| goPackagePath = "github.com/candid82/joker"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| inherit rev; |
There was a problem hiding this comment.
Prefer git tag: rev = "v${version}"
| homepage = https://github.com/candid82/joker; | ||
| description = "A small Clojure interpreter and linter written in Go"; | ||
| license = licenses.epl10; | ||
| platforms = stdenv.lib.platforms.all; |
There was a problem hiding this comment.
Please delete stdenv.lib here and below.
|
I've opened an issue at upstream as v0.8.5 had a problem that was preventing it from building correctly. Now v0.8.6 has been released, builds correctly here and I've updated the PR. Should I update the PR name or commit message to correctly reflect that it's v0.8.6? |
|
Sure, could you squash the commits into one with |
|
Additionally I've prevented the installation of generators that were not meant to be installed into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding Joker, a Clojure interpreter/linter written in go.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)