Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace debug (pll|mmcm) with debug clocks #365

Merged
merged 1 commit into from Oct 30, 2017

Conversation

stefanor
Copy link
Contributor

Only one of these will be active, and output anything, so let's just run both, under the hood.

firmware/ci.c Outdated
@@ -161,8 +162,7 @@ static void help_debug(void)
#ifdef CSR_GENERATOR_BASE
wputs(" debug sdram_test - run a memory test");
#endif
wputs(" debug pll - dump pll configuration");
wputs(" debug mmcm - dump mmcm configuration");
wputs(" debug clock - dump pll/mmcm configuration");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be debug clocks I think?

@mithro mithro self-requested a review October 30, 2017 00:07
@stefanor stefanor changed the title Replace debug (pll|mmcm) with debug clock Replace debug (pll|mmcm) with debug clocks Oct 30, 2017
@@ -32,7 +32,7 @@ if [ ! -z "$SETTINGS_FILE" -o ! -z "$XILINX" ]; then
fi

# Check ixo-usb-jtag *isn't* install
if [ -d /lib/firmware/ixo-usb-jtag/ ]; then
if [ ! -d /lib/firmware/ixo-usb-jtag/ ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I always have this dirty in my checkout. Sorry.

Only one of these will be active, and output anything, so let's just run
both, under the hood.
@mithro
Copy link
Member

mithro commented Oct 30, 2017

LGTM!

@mithro mithro merged commit ccb30b9 into timvideos:master Oct 30, 2017
@stefanor stefanor deleted the debug-clock branch October 30, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants