New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace debug (pll|mmcm) with debug clocks #365
Conversation
firmware/ci.c
Outdated
@@ -161,8 +162,7 @@ static void help_debug(void) | |||
#ifdef CSR_GENERATOR_BASE | |||
wputs(" debug sdram_test - run a memory test"); | |||
#endif | |||
wputs(" debug pll - dump pll configuration"); | |||
wputs(" debug mmcm - dump mmcm configuration"); | |||
wputs(" debug clock - dump pll/mmcm configuration"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be debug clocks
I think?
scripts/enter-env.sh
Outdated
@@ -32,7 +32,7 @@ if [ ! -z "$SETTINGS_FILE" -o ! -z "$XILINX" ]; then | |||
fi | |||
|
|||
# Check ixo-usb-jtag *isn't* install | |||
if [ -d /lib/firmware/ixo-usb-jtag/ ]; then | |||
if [ ! -d /lib/firmware/ixo-usb-jtag/ ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I always have this dirty in my checkout. Sorry.
Only one of these will be active, and output anything, so let's just run both, under the hood.
LGTM! |
Only one of these will be active, and output anything, so let's just run both, under the hood.