Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add section on common darwin issues #30951

Merged
merged 1 commit into from Nov 5, 2017
Merged

docs: add section on common darwin issues #30951

merged 1 commit into from Nov 5, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 30, 2017

Motivation for this change

Fixes #1549

Things done
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

orivej
orivej approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have put this chapter after the Package Notes section under the name Platform Notes.

@orivej orivej merged commit 48cacf5 into NixOS:master Nov 5, 2017
@LnL7 LnL7 deleted the darwin-docs branch November 5, 2017 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @orivej @GrahamcOfBorg