Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sxiv: installs .desktop file #30953

Merged
merged 1 commit into from Oct 30, 2017
Merged

sxiv: installs .desktop file #30953

merged 1 commit into from Oct 30, 2017

Conversation

teto
Copy link
Member

@teto teto commented Oct 30, 2017

sxiv won't appear in meus as it has NoDisplay but it can be used to
generate the mimetypes.

Motivation for this change

my pngs opened with wrong program

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 5c35db3 into NixOS:master Oct 30, 2017
@teto teto deleted the sxiv branch October 30, 2017 09:00
@teto
sxiv: installs .desktop file
cdbcb19 
sxiv won't appear in meus as it has NoDisplay but it can be used to
generate the mimetypes.
@unode
Copy link
Member

unode commented Dec 13, 2017 •
edited

Any chance this could be backported to nixos-17.09. Thanks.
Just ran into the same issue described (wrong program used and sxiv doesn't show up on list of options)

@joachifm
Copy link
Contributor

Sure, I'll add it to my queue. Btw. you can always open cherry-pick PRs against the release branch for stuff you want backported (please use cherry-pick -x to maintain a link to the original commit & explain why it needs to be backported). Sometimes fixes like this can slip through the cracks :)

@joachifm
Copy link
Contributor

Picked at 6089a58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @unode @joachifm