New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emojione: add fontconfig module #30936
Conversation
Have you tested this? I don't think it will work because NixOS' version of cairo doesn't support colour glyphs yet, though maybe I'm wrong. |
Yes, I have being using it for some months now. |
Does it work only in the browser or everywhere? |
You're right it only work in the browser, other software support only black and white emojii. For the moment I view emojii only in the browser so I didn't checked in other apps. |
type = types.bool; | ||
default = false; | ||
description = '' | ||
Enable emojione settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this to something more descriptive, such as Display all emoji with the emojione font.
?
|
||
config = mkIf (config.fonts.fontconfig.enable && cfg.enable) { | ||
|
||
fonts.fontconfig.confPackages = [ confPkg ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides installing the Fontconfig files, I think this module should install the emojione
font. Otherwise, users must make two settings in their configuration.nix
.
I don't think this is the right approach. I think we should add
|
Also, that might not be needed anymore in the latest fontconfig. |
Thanks for the comment @yegortimoshenko, that was what I was looking for when I wrote this push request. This PR works but seems dirty. I'll test your way of having emoji on NixOS. However I think there should be a option to enable emoji or at least a clear documentation on how to enable it. |
@bricewge I think that was fixed in https://bugs.freedesktop.org/show_bug.cgi?id=94551, i.e. it should automatically discover proper color emoji set w/o falling back to DejaVu. |
Motivation for this change
It add a new NixOS option to add emojjione's config to fontconfig. When enabled emoji characters are render with only one font –emojione– and not several as it is currently. It can be seen here: http://getemoji.com/
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)