Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: added requests_oauthlib to propagatedBuildInputs #30921

Merged
merged 1 commit into from Oct 29, 2017

Conversation

andir
Copy link
Member

@andir andir commented Oct 29, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

vdirsyncer requires `requests_oauthlib` in order to work with google
calendar sync services
@andir andir force-pushed the vdirsyncer-requests_oauthlib branch from 1606522 to 335add9 Compare October 29, 2017 10:42
@FRidh
Copy link
Member

FRidh commented Oct 29, 2017

cc maintainers @matthiasbeyer @jgeerds

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with it, though I cannot test as I'm not using google oauth sync.

@andir
Copy link
Member Author

andir commented Oct 29, 2017 via email

@FRidh FRidh merged commit f04f30f into NixOS:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants