Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move my python packages to python-modules/ #30932

Merged
merged 23 commits into from Oct 29, 2017

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Easier maintenance.

Also, I'm adding a few package updates here too, which I feel are safe.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 29, 2017

👍
Needs a rebase though.

@FRidh
Copy link
Member

FRidh commented Oct 29, 2017

One remark. If expressions have pname and version attributes, then they can more easily be updated with maintainers/scripts/update-python-libraries

The pep8 package is renamed to pycodestyle and autopep8 references the
new name.

(Also, fetchurl -> fetchPypi.)
* fetchurl -> fetchPypi
* Tests work now.
* Package is py3k compatible now.
Also, fetchurl -> fetchPypi.
@bjornfor
Copy link
Contributor Author

One remark. If expressions have pname and version attributes, then they can more easily be updated with maintainers/scripts/update-python-libraries

Thanks! I'll have a look.

@bjornfor bjornfor merged commit ccc1f9a into NixOS:master Oct 29, 2017
@bjornfor bjornfor deleted the move-my-python-pkgs branch October 29, 2017 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants