Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-scrypt: init at 1.2 #30930

Closed
wants to merge 1 commit into from
Closed

Conversation

richardipsum
Copy link
Contributor

Hi!

Motivation for this change

I'm in the process of adding a git service called Gitano to Nix.
A fair few of the dependencies are now already packaged, this is the last of the dependencies
that aren't "gitano-core" dependencies.

Once this is merged, I'll open another PR that will actually add Gitano and its core dependencies in one shot.

Thanks!
Richard

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Oct 29, 2017

@GrahamcOfBorg luaPackages.lua-scrypt

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-darwin

error: attribute 'lua-scrypt' in selection path 'lua-scrypt' not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-linux

error: attribute ‘lua-scrypt’ in selection path ‘lua-scrypt’ not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-linux

installing
install flags: install SHELL=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash PREFIX=\$\(out\) LUA_LIBDIR=\$\(out\)/lib/lua/5.2 LUA_INC=-I/nix/store/nji219mfmlyxysqll64mdd8vjcaqb9zd-lua-5.2.3/include CFLAGS+=-DTRUST_LIBSCRYPT_SALT_GEN INST_LIBDIR=/nix/store/5js2mgj5l1dq6g6jsi79hk6bzh39w9hq-lua5.2-lua-scrypt-1.2/lib/lua/5.2 INST_LUADIR=/nix/store/5js2mgj5l1dq6g6jsi79hk6bzh39w9hq-lua5.2-lua-scrypt-1.2/share/lua/5.2 LUA_BINDIR=/nix/store/5js2mgj5l1dq6g6jsi79hk6bzh39w9hq-lua5.2-lua-scrypt-1.2/bin LUA_INCDIR=-I/nix/store/nji219mfmlyxysqll64mdd8vjcaqb9zd-lua-5.2.3/include LUA_LIBDIR=-L/nix/store/nji219mfmlyxysqll64mdd8vjcaqb9zd-lua-5.2.3/lib
lua-scrypt: Lua 5.2 package name on this system is lua
lua-scrypt: Lua 5.1 could not be found, so lua-scrypt was not installed for it.
ln -s -f scrypt-5.2.so scrypt.so
/usr/bin/install -d /nix/store/5js2mgj5l1dq6g6jsi79hk6bzh39w9hq-lua5.2-lua-scrypt-1.2/lib/lua/5.2
/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash: /usr/bin/install: No such file or directory
make: *** [Makefile:48: lua-5.2-install] Error 127
builder for ‘/nix/store/md8r9ylvc3f6kmw213jcvwxjxpigksma-lua5.2-lua-scrypt-1.2.drv’ failed with exit code 2
error: build of ‘/nix/store/md8r9ylvc3f6kmw213jcvwxjxpigksma-lua5.2-lua-scrypt-1.2.drv’ failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-darwin

  "_lua_pushboolean", referenced from:
      _luascrypt_verify_password in luascrypt-cea921.o
  "_lua_pushstring", referenced from:
      _luascrypt_hash_password in luascrypt-cea921.o
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:52: scrypt-5.2.so] Error 1
builder for '/nix/store/42h48vpi4wyif5s0d04fq337h4yaz033-lua5.2-lua-scrypt-1.2.drv' failed with exit code 2
error: build of '/nix/store/42h48vpi4wyif5s0d04fq337h4yaz033-lua5.2-lua-scrypt-1.2.drv' on 'ssh://mac1' failed: builder for '/nix/store/42h48vpi4wyif5s0d04fq337h4yaz033-lua5.2-lua-scrypt-1.2.drv' failed with exit code 2
error: build of '/nix/store/42h48vpi4wyif5s0d04fq337h4yaz033-lua5.2-lua-scrypt-1.2.drv' failed

@richardipsum
Copy link
Contributor Author

I have no idea why this doesn't work on OSX. That is not a platform I have to hand right now, I will try and look at this tomorrow.

@richardipsum
Copy link
Contributor Author

richardipsum commented Oct 29, 2017

Actually I suspect this will just be a difference in linker options between GNU/Linux and OSX. This is not something I'm able to fix immediately since I don't have access to OSX, but I will try to fix this as soon as I can.

@vyp
Copy link
Member

vyp commented Oct 29, 2017

Hmm it failed for Linux too.

@richardipsum
Copy link
Contributor Author

@vyp Yeah I think that's just a case of setting INSTALL.

@vyp
Copy link
Member

vyp commented Oct 30, 2017

Oh yeah thanks I missed that 🤦‍♀️

@richardipsum
Copy link
Contributor Author

I asked around in #lua on freenode and it turns out that on OSX you need some extra compiler flags to get this to work, -undefined dynamic_lookup, I'll fix this up as soon as I can.

@vyp
Copy link
Member

vyp commented Nov 1, 2017

Nice work, and yeah I can't really help with darwin btw since I don't have access to such a machine.

@richardipsum
Copy link
Contributor Author

I abandon this change, sorry. @kinnison

@orivej
Copy link
Contributor

orivej commented Dec 16, 2017

@richardipsum Will you continue with Gitano if we finish this PR for you?

@richardipsum
Copy link
Contributor Author

@orivej Not likely, sorry, I no longer have any motivation to maintain Gitano pkgs or any dependencies. It was quite a lot of effort on my part to get it this far. I have the whole set working in draft form at https://github.com/richardipsum/nixpkgs/tree/gitano. Feel free to pick up my pkgs if you like, speak to @kinnison (upstream maintainer) or send any queries to upstream at gitano-dev@gitano.org.uk

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants