Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-48: Fix delete trigger generation for tables without gid #51

Closed
wants to merge 0 commits into from
Closed

SOLR-48: Fix delete trigger generation for tables without gid #51

wants to merge 0 commits into from

Conversation

samj1912
Copy link
Contributor

No description provided.

@mwiencek
Copy link
Member

It's perhaps true that all the tables we care about only either use id or gid as their primary key, but I think having separate classes for each primary key name might be an unnecessary pattern. Why not just have a single DeleteTriggerGenerator class and pass it the list of primary keys used by the table? At least it looks to me like that list already exists: https://github.com/samj1912/sir/blob/798349ce0d5663d3f43697a9a8e635a41726ff6b/sir/trigger_generation/__init__.py#L123

@samj1912 samj1912 closed this Oct 30, 2017
@samj1912 samj1912 mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mineo mineo Awaiting requested review from mineo

@mwiencek mwiencek Awaiting requested review from mwiencek

@mayhem mayhem Awaiting requested review from mayhem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@samj1912 @mwiencek