Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mupdf: correct license meta information #30933

Merged
merged 1 commit into from Oct 30, 2017
Merged

mupdf: correct license meta information #30933

merged 1 commit into from Oct 30, 2017

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Oct 29, 2017

Motivation for this change

The license stated in the Nix file, GPL >= 3, is not the license which MuPDF is really distributed under. It's AGPL >= 3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@iblech
mupdf: correct license meta information
3afcba3 
The website of MuPDF says that MuPDF is licensed under the terms of the GNU 
Affero General Public License. However, I didn't see which version of that
license they mean.

A clear statement that MuPDF is licensed under the terms of AGPL >= 3 is 
included in the README file of their Git repository:

    git://git.ghostscript.com/mupdf.git
vyp
vyp approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@vyp vyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@orivej orivej merged commit dc309e9 into NixOS:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iblech @vyp @orivej