Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make firmware-clear #363

Merged
merged 7 commits into from Oct 30, 2017
Merged

Add make firmware-clear #363

merged 7 commits into from Oct 30, 2017

Conversation

stefanor
Copy link
Contributor

No description provided.

@mithro
Copy link
Member

mithro commented Oct 29, 2017

The other targets/**/Makefile.mk need this target now too.

I have no idea if anything else even supports the concept.
We wouldn't want to leave production mode, if that was where we were.
Makefile Outdated
@@ -321,6 +324,8 @@ help:
@echo " make firmware-load - *Temporarily* load the firmware onto a device"
@echo " make firmware-flash - *Permanently* flash the firmware onto a device"
@echo " make firmware-connect - *Connect* to the firmware running on a device"
@echo " make firmware-clear - *Permenantly* erase the firmware on the device,"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line or the one above it has a spelling mistake?

@mithro
Copy link
Member

mithro commented Oct 30, 2017

Did you want to do the move of the .PHONY lines into the top level Makefile, or should I merge this now and you will do that later?

@stefanor
Copy link
Contributor Author

Let's do it now...

@mithro
Copy link
Member

mithro commented Oct 30, 2017

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants